dongjoon-hyun commented on code in PR #41499:
URL: https://github.com/apache/spark/pull/41499#discussion_r1221891159
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -288,7 +288,8 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
.orElse(createCartesianProduct())
.getOrElse {
// This join could be very slow or OOM
- val buildSide = getSmallerSide(left, right)
+ val requiredBuildSide = getBroadcastNestedLoopJoinBuildSide(hint)
+ val buildSide = requiredBuildSide.getOrElse(getSmallerSide(left,
right))
Review Comment:
Could you add a comment about these two-line change because this is more
complex than a single `getSmallerSide`, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
