hiboyang commented on code in PR #10:
URL: https://github.com/apache/spark-connect-go/pull/10#discussion_r1223409376
##########
client/sql/dataframe.go:
##########
@@ -31,6 +31,7 @@ type DataFrame interface {
Show(numRows int, truncate bool) error
Schema() (*StructType, error)
Collect() ([]Row, error)
+ Write() DataFrameWriter
}
type dataFrameImpl struct {
Review Comment:
How about split the file when it becomes big (e.g. more than 1000 or 2000
lines)?
In Golang, it is difficult to find out which structs implement which
interfaces, since Go structs does not explicitly declare what interfaces they
implement (Go uses method matching to determine what interfaces a struct
implements). If a file is not huge, placing interface and implementation struct
in the same file will make it easy to track the implementation relationship of
interfaces/structs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
