hiboyang commented on code in PR #10:
URL: https://github.com/apache/spark-connect-go/pull/10#discussion_r1223599098
##########
client/sql/dataframe.go:
##########
@@ -31,6 +31,7 @@ type DataFrame interface {
Show(numRows int, truncate bool) error
Schema() (*StructType, error)
Collect() ([]Row, error)
+ Write() DataFrameWriter
Review Comment:
Added document.
##########
client/sql/dataframereader.go:
##########
@@ -0,0 +1,41 @@
+package sql
+
+import proto "github.com/apache/spark-connect-go/v_3_4/internal/generated"
+
+type DataFrameReader interface {
Review Comment:
Yes!
##########
client/sql/dataframereader.go:
##########
@@ -0,0 +1,41 @@
+package sql
+
+import proto "github.com/apache/spark-connect-go/v_3_4/internal/generated"
+
+type DataFrameReader interface {
+ Format(source string) DataFrameReader
+ Load(path string) (DataFrame, error)
Review Comment:
Good suggestion, added TODO for missing methods.
##########
client/sql/dataframewriter.go:
##########
@@ -0,0 +1,79 @@
+package sql
+
+import (
+ "fmt"
+ proto "github.com/apache/spark-connect-go/v_3_4/internal/generated"
+ "strings"
+)
+
+type DataFrameWriter interface {
Review Comment:
Yes!
##########
client/sql/sparksession.go:
##########
@@ -154,3 +163,17 @@ func (s *sparkSessionImpl) analyzePlan(plan *proto.Plan)
(*proto.AnalyzePlanResp
}
return response, nil
}
+
+func consumeExecutePlanClient(responseClient
proto.SparkConnectService_ExecutePlanClient) error {
Review Comment:
Yes, added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
