panbingkun opened a new pull request, #41572:
URL: https://github.com/apache/spark/pull/41572

   ### What changes were proposed in this pull request?
   The pr aims to improve for PlanGenerationTestSuite & 
ProtoToParsedPlanTestSuite, include:
   - When generating `GOLDEN` files, we should first delete the corresponding 
directories and generate new ones to avoid submitting some redundant files 
during the review process. eg:
   When we write a test named `make_timestamp_ltz` for the overloaded method, 
and during the review process, the reviewer wishes to add more tests for the 
method. At this point, if the `queries/function_make_timestamp_ltz.json`, 
`queries/function_make_timestamp_ltz.proto.bin` and 
`explain-results/function_make_timestamp_ltz.explain` files of 
`function_make_timestamp_ltz` are already in the commit, and there are many of 
these files, we generally do not notice the above problem, which leads to the 
incorrect submission of `queries/function_make_timestamp_ltz.json`, 
`queries/function_make_timestamp_ltz.proto.bin` and 
`explain-results/function_make_timestamp_ltz.explain` files without any impact 
on UT. These files are redundant.
   
   - Clear and update some redundant files submitted incorrectly
   
   ### Why are the changes needed?
   Make code clear.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Pass GA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to