beliefer commented on code in PR #41572:
URL: https://github.com/apache/spark/pull/41572#discussion_r1228098821
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -103,6 +104,12 @@ class PlanGenerationTestSuite
val client =
SparkConnectClient(InProcessChannelBuilder.forName("/dev/null").build())
session =
new SparkSession(client, cleaner = SparkSession.cleaner, planIdGenerator
= new AtomicLong)
+ if (regenerateGoldenFiles) {
Review Comment:
Good catch! Thank you ! Personally, I feet delete all golden files and
regenerate is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
