panbingkun commented on code in PR #41561:
URL: https://github.com/apache/spark/pull/41561#discussion_r1231696960
##########
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:
##########
@@ -872,4 +872,95 @@ class StringFunctionsSuite extends QueryTest with
SharedSparkSession {
Seq(Row(78.12))
)
}
+
+ test("char & chr function") {
+ val df = Seq(65).toDF("a")
+ checkAnswer(df.selectExpr("char(a)"), Seq(Row("A")))
+ checkAnswer(df.select(char(col("a"))), Seq(Row("A")))
+
+ checkAnswer(df.selectExpr("chr(a)"), Seq(Row("A")))
+ checkAnswer(df.select(chr(col("a"))), Seq(Row("A")))
+ }
+
+ test("btrim function") {
+ val df = Seq(("SSparkSQLS", "SL")).toDF("a", "b")
+
+ checkAnswer(df.selectExpr("btrim(a)"), Seq(Row("SSparkSQLS")))
+ checkAnswer(df.select(btrim(col("a"))), Seq(Row("SSparkSQLS")))
+
+ checkAnswer(df.selectExpr("btrim(a, b)"), Seq(Row("parkSQ")))
+ checkAnswer(df.select(btrim(col("a"), col("b"))), Seq(Row("parkSQ")))
+ }
+
+ test("char_length & character_length function") {
+ val df = Seq("SSparkSQLS").toDF("a")
+ checkAnswer(df.selectExpr("char_length(a)"), Seq(Row(10)))
+ checkAnswer(df.select(char_length(col("a"))), Seq(Row(10)))
+
+ checkAnswer(df.selectExpr("character_length(a)"), Seq(Row(10)))
+ checkAnswer(df.select(character_length(col("a"))), Seq(Row(10)))
+ }
+
+ test("contains function") {
+ // TODO
+ val df = Seq(("Spark SQL", "Spark")).toDF("a", "b")
+ checkAnswer(df.selectExpr("contains(a, b)"), Seq(Row(true)))
+ checkAnswer(df.select(contains(lit("Spark SQL"), lit("Spark"))),
Seq(Row(true)))
Review Comment:
Why not `df.select(contains(col("a"), col("b")))`, but`contains(lit("Spark
SQL"), lit("Spark")))`, because here it can't get the datatype.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
