zhengruifeng commented on code in PR #41561:
URL: https://github.com/apache/spark/pull/41561#discussion_r1231697690
##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -3563,6 +3563,186 @@ object functions {
ToNumber(e.expr, format.expr)
}
+ /**
+ * Returns the ASCII character having the binary equivalent to `n`.
+ * If n is larger than 256 the result is equivalent to char(n % 256)
+ *
+ * @group string_funcs
+ * @since 3.5.0
+ */
+ def char(n: Column): Column = withExpr {
+ Chr(n.expr)
+ }
+
+ /**
+ * Removes the leading and trailing space characters from `str`.
+ *
+ * @group string_funcs
+ * @since 3.5.0
+ */
+ def btrim(str: Column): Column = withExpr {
+ new StringTrimBoth(str.expr)
+ }
+
+ /**
+ * Remove the leading and trailing `trim` characters from `str`.
+ *
+ * @group string_funcs
+ * @since 3.5.0
+ */
+ def btrim(str: Column, trim: Column): Column = withExpr {
+ new StringTrimBoth(str.expr, trim.expr)
+ }
+
+ /**
+ * Returns the character length of string data or number of bytes of binary
data.
+ * The length of string data includes the trailing spaces.
+ * The length of binary data includes binary zeros.
+ *
+ * @group string_funcs
+ * @since 3.5.0
+ */
+ def char_length(str: Column): Column = withExpr {
+ Length(str.expr)
+ }
+
+ /**
+ * Returns the character length of string data or number of bytes of binary
data.
+ * The length of string data includes the trailing spaces.
+ * The length of binary data includes binary zeros.
+ *
+ * @group string_funcs
+ * @since 3.5.0
+ */
+ def character_length(str: Column): Column = withExpr {
+ Length(str.expr)
+ }
+
+ /**
+ * Returns the ASCII character having the binary equivalent to `n`.
+ * If n is larger than 256 the result is equivalent to chr(n % 256)
+ *
+ * @group string_funcs
+ * @since 3.5.0
+ */
+ def chr(n: Column): Column = withExpr {
+ Chr(n.expr)
+ }
+
+ /**
+ * Returns a boolean. The value is True if right is found inside left.
+ * Returns NULL if either input expression is NULL. Otherwise, returns False.
+ * Both left or right must be of STRING or BINARY type.
+ *
+ * @group string_funcs
+ * @since 3.5.0
+ */
+ def contains(left: Column, right: Column): Column = withExpr {
+ ContainsExpressionBuilder.build("contains", Seq(left.expr, right.expr))
Review Comment:
I think we should only support `StringType` here, and document this
limitation (`contains` in sql support both `StringType` and `BinaryType`).
also cc @HyukjinKwon @beliefer @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
