cloud-fan commented on code in PR #41656:
URL: https://github.com/apache/spark/pull/41656#discussion_r1233641163
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala:
##########
@@ -1200,6 +1148,71 @@ class PlanResolutionSuite extends AnalysisTest {
}
case _ => fail("Expect UpdateTable, but got:\n" + parsed2.treeString)
}
+
+ val sql3 = "UPDATE testcat.defaultvalues SET i=DEFAULT, s=DEFAULT"
+ val sql4 = "UPDATE testcat.defaultvalues2 SET i=DEFAULT"
+ // Table with ACCEPT_ANY_SCHEMA can also resolve the column DEFAULT.
+ val sql5 = "UPDATE testcat.v2TableWithAcceptAnySchemaCapability SET
i=DEFAULT"
+
+ val parsed3 = parseAndResolve(sql3)
+ val parsed4 = parseAndResolve(sql4)
+ val parsed5 = parseAndResolve(sql5)
+
+ parsed3 match {
+ case UpdateTable(
+ _,
+ Seq(
+ Assignment(i: AttributeReference, Literal(true, BooleanType)),
+ Assignment(s: AttributeReference, Literal(42, IntegerType))),
+ None) =>
+ assert(i.name == "i")
+ assert(s.name == "s")
+
+ case _ => fail("Expect UpdateTable, but got:\n" + parsed3.treeString)
+ }
+
+ parsed4 match {
+ case UpdateTable(
+ _,
+ Seq(Assignment(i: AttributeReference, Literal(null, StringType))),
+ None) =>
+ assert(i.name == "i")
+
+ case _ => fail("Expect UpdateTable, but got:\n" + parsed4.treeString)
+ }
+
+ parsed5 match {
+ case UpdateTable(
+ _,
+ Seq(Assignment(i: AttributeReference, Literal(null, IntegerType))),
+ None) =>
+ assert(i.name == "i")
+
+ case _ => fail("Expect UpdateTable, but got:\n" + parsed5.treeString)
+ }
+
+ // Negative cases.
+ // UPDATE condition won't resolve column "DEFAULT"
+ val sql6 = "UPDATE testcat.defaultvalues SET i=DEFAULT, s=DEFAULT WHERE
i=DEFAULT"
+ checkError(
+ exception = intercept[AnalysisException] {
+ parseAndResolve(sql6, checkAnalysis = true)
+ },
+ errorClass = "UNRESOLVED_COLUMN.WITH_SUGGESTION",
+ parameters = Map("objectName" -> "`DEFAULT`", "proposal" -> "`i`, `s`"),
+ context = ExpectedContext(
+ fragment = "DEFAULT",
+ start = 62,
+ stop = 68))
+
+ val sql7 = "UPDATE testcat.tab2 SET x=DEFAULT"
Review Comment:
this is the new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
