cloud-fan commented on code in PR #41656:
URL: https://github.com/apache/spark/pull/41656#discussion_r1233641755
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala:
##########
@@ -1941,6 +1906,110 @@ class PlanResolutionSuite extends AnalysisTest {
fail("Expect MergeIntoTable, but got:\n" + other.treeString)
}
+ // DEFAULT column reference in the merge condition:
+ // This MERGE INTO command includes an ON clause with a DEFAULT column
reference. This
+ // DEFAULT column won't be resolved.
+ val mergeWithDefaultReferenceInMergeCondition =
+ """
+ |MERGE INTO testcat.tab AS target
+ |USING testcat.tab1 AS source
+ |ON target.i = DEFAULT
+ |WHEN MATCHED AND (target.s = 31) THEN DELETE
+ |WHEN MATCHED AND (target.s = 31)
+ | THEN UPDATE SET target.s = DEFAULT
+ |WHEN NOT MATCHED AND (source.s='insert')
+ | THEN INSERT (target.i, target.s) values (DEFAULT, DEFAULT)
+ |WHEN NOT MATCHED BY SOURCE AND (target.s = 31) THEN DELETE
+ |WHEN NOT MATCHED BY SOURCE AND (target.s = 31)
+ | THEN UPDATE SET target.s = DEFAULT
+ |""".stripMargin
+ checkError(
+ exception = intercept[AnalysisException] {
+ parseAndResolve(mergeWithDefaultReferenceInMergeCondition,
checkAnalysis = true)
+ },
+ errorClass = "UNRESOLVED_COLUMN.WITH_SUGGESTION",
+ parameters = Map("objectName" -> "`DEFAULT`",
+ "proposal" -> "`target`.`i`, `source`.`i`, `target`.`s`,
`source`.`s`"),
+ context = ExpectedContext(
+ fragment = "DEFAULT",
+ start = 77,
+ stop = 83))
+
+ // DEFAULT column reference within a complex expression:
+ // This MERGE INTO command includes a WHEN MATCHED clause with a DEFAULT
column reference as
+ // of a complex expression (DEFAULT + 1). This is invalid and column won't
be resolved.
+ val mergeWithDefaultReferenceAsPartOfComplexExpression =
+ """
+ |MERGE INTO testcat.tab AS target
+ |USING testcat.tab1 AS source
+ |ON target.i = source.i
+ |WHEN MATCHED AND (target.s = 31) THEN DELETE
+ |WHEN MATCHED AND (target.s = 31)
+ | THEN UPDATE SET target.s = DEFAULT + 1
+ |WHEN NOT MATCHED AND (source.s='insert')
+ | THEN INSERT (target.i, target.s) values (DEFAULT, DEFAULT)
+ |WHEN NOT MATCHED BY SOURCE AND (target.s = 31) THEN DELETE
+ |WHEN NOT MATCHED BY SOURCE AND (target.s = 31)
+ | THEN UPDATE SET target.s = DEFAULT + 1
+ |""".stripMargin
+ checkError(
+ exception = intercept[AnalysisException] {
+ parseAndResolve(mergeWithDefaultReferenceAsPartOfComplexExpression)
+ },
+ errorClass = "_LEGACY_ERROR_TEMP_1343",
+ parameters = Map.empty)
+
+ val mergeWithDefaultReferenceForNonNullableCol =
Review Comment:
this is the new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
