ryan-johnson-databricks commented on code in PR #41777:
URL: https://github.com/apache/spark/pull/41777#discussion_r1245939685


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -253,7 +253,9 @@ class CacheManager extends Logging with 
AdaptiveSparkPlanHelper {
    * Tries to re-cache all the cache entries that refer to the given plan.
    */
   def recacheByPlan(spark: SparkSession, plan: LogicalPlan): Unit = {
-    recacheByCondition(spark, _.plan.exists(_.sameResult(plan)))
+    if 
(spark.sessionState.conf.getConf(SQLConf.QUERY_RESULT_CACHE_AUTO_REFRESH)) {

Review Comment:
   We can avoid the indentation change by an early return above it?
   (not sure if that matters)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to