amaliujia commented on code in PR #41777:
URL: https://github.com/apache/spark/pull/41777#discussion_r1246021348
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -253,7 +253,9 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
* Tries to re-cache all the cache entries that refer to the given plan.
*/
def recacheByPlan(spark: SparkSession, plan: LogicalPlan): Unit = {
- recacheByCondition(spark, _.plan.exists(_.sameResult(plan)))
+ if
(spark.sessionState.conf.getConf(SQLConf.QUERY_RESULT_CACHE_AUTO_REFRESH)) {
Review Comment:
I just remember we talked about this: so a better API design is that we do
not access the SQLConf as this but have it passed into this method from the
caller where it has better chance to load all SQLConf and decide where to use.
However we have been using this way to get SQLConf so this is fine as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
