cdkrot commented on code in PR #41807:
URL: https://github.com/apache/spark/pull/41807#discussion_r1251745935
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -628,8 +625,13 @@ object SparkSession extends Logging {
/**
* Create a new [[SparkSession]] based on the connect client
[[Configuration]].
*/
- private[sql] def create(configuration: Configuration): SparkSession = {
- new SparkSession(new SparkConnectClient(configuration), cleaner,
planIdGenerator)
+ private[sql] def create(
+ configuration: Configuration,
+ channelBuilder: Option[ChannelBuilder] = None): SparkSession = {
Review Comment:
https://github.com/apache/spark/blob/7fcabef28743099363c5cf21b90e987e6be90b12/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala#L463..L474
ChannelBuilder could be part of it because it's also part of
SparkConnectClient's configuration
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -628,8 +625,13 @@ object SparkSession extends Logging {
/**
* Create a new [[SparkSession]] based on the connect client
[[Configuration]].
*/
- private[sql] def create(configuration: Configuration): SparkSession = {
- new SparkSession(new SparkConnectClient(configuration), cleaner,
planIdGenerator)
+ private[sql] def create(
+ configuration: Configuration,
+ channelBuilder: Option[ChannelBuilder] = None): SparkSession = {
Review Comment:
https://github.com/apache/spark/blob/7fcabef28743099363c5cf21b90e987e6be90b12/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala#L463
ChannelBuilder could be part of it because it's also part of
SparkConnectClient's configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
