nija-at commented on code in PR #41807:
URL: https://github.com/apache/spark/pull/41807#discussion_r1251762819
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/SparkSessionSuite.scala:
##########
@@ -73,4 +78,21 @@ class SparkSessionSuite extends ConnectFunSuite {
session2.close()
}
}
+
+ class CustomChannelBuilder() extends ChannelBuilder() {
+ override def createChannelBuilder(
+ host: String,
+ port: Int,
+ credentials: ChannelCredentials): ManagedChannelBuilder[_] = {
+
+ val builder = super.createChannelBuilder(host, port, credentials)
+ builder.userAgent("Custom agent")
+ builder
+ }
+ }
+
+ test("channelBuilder") {
+ val channelBuilder = new CustomChannelBuilder()
+
SparkSession.builder().remote("sc://test.it:16845").channelBuilder(channelBuilder).create()
Review Comment:
I assume you've created CustomChannelBuilder and setting user agent with the
intent to verify that this actually shows up somewhere, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
