maheshk114 opened a new pull request, #41860:
URL: https://github.com/apache/spark/pull/41860
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
In the current code, to check if a join is a shuffle join or not, left
and right sides are interchanged. This is not correct as for few joins the left
and right side are considered to check if a join is shuffle or not. This PR
has moved the check to a place where left and right side are know. Then the
value is used for verification at other places.
The method checking if the join is a shuffle or not is not taking join type
into consideration. Added a extra parameter in isProbablyShuffleJoin method and
used it to determine if the join is a shuffle join or not.
### Why are the changes needed?
The left side of left outer join is not broadcasted even if its small enough
to avoid incorrect result. One of the ways to optimize this is using bloom
filter. This helps in reducing the size of right size. But bloom filter is not
created if the filter creation side is small enough to be broadcasted. This is
causing small left outer join relation are neither broadcasted nor able to use
bloom filter. So we need to add a check in bloom filter to allow bloom filter
for left outer, right outer and semi joins even if the size is small enough to
be broadcasted.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
