oss-maker commented on code in PR #41860:
URL: https://github.com/apache/spark/pull/41860#discussion_r1253951425
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -185,14 +186,18 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
}
private def isProbablyShuffleJoin(left: LogicalPlan,
- right: LogicalPlan, hint: JoinHint): Boolean = {
- !hintToBroadcastLeft(hint) && !hintToBroadcastRight(hint) &&
- !canBroadcastBySize(left, conf) && !canBroadcastBySize(right, conf)
+ right: LogicalPlan,
+ hint: JoinHint,
+ joinType: JoinType): Boolean = {
Review Comment:
Could you please indent this better, use 4 spaces starting from the function
definition for every parameter on new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
