hvanhovell commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1257243793
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
* @since 2.0.0
*/
@scala.annotation.varargs
- def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {
Review Comment:
TBH I am not sure what is worse. The problem I foresee here is that
expressions use SQLConf.get to get a configuration, and now we don't know what
setting they will pick-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
