hvanhovell commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1257245311
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/CatalystSqlParser.scala:
##########
@@ -16,11 +16,13 @@
*/
package org.apache.spark.sql.catalyst.parser
+import org.apache.spark.sql.internal.SQLConf
+
/**
* Concrete SQL parser for Catalyst-only SQL statements.
*/
class CatalystSqlParser extends AbstractSqlParser {
Review Comment:
It needs SQLConf for ANSI mode. It does make a difference for what we allow
in terms of keywords. It is not super problematic because you can typically fix
this by quoting identifiers, the only problem is that within the same session
you could have different parsing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
