HyukjinKwon commented on code in PR #41947:
URL: https://github.com/apache/spark/pull/41947#discussion_r1260419611
##########
python/pyspark/testing/utils.py:
##########
@@ -243,6 +245,10 @@ def assertDataFrameEqual(df: DataFrame, expected:
DataFrame, check_row_order: bo
If set to `False` (default), the row order is not taken into account.
If set to `True`, the order of rows is important and will be checked
during comparison.
+ precision : float, optional
+ The level of precision when asserting approximate equality for float
values in df
+ and expected. Set to 1e-5 by default.
Review Comment:
Maybe it's okay for now. but I think you should probably take a look at
other libraries such as NumPy's allclose `rtol` and `atol`
https://numpy.org/doc/stable/reference/generated/numpy.allclose.html#numpy-allclose.
I think the name has to better be tolerance but don't have a strong
preference. cc @zhengruifeng and @WeichenXu123 in case you guys have some
feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
