asl3 commented on code in PR #41947:
URL: https://github.com/apache/spark/pull/41947#discussion_r1262060087
##########
python/pyspark/testing/utils.py:
##########
@@ -221,7 +221,13 @@ def check_error(
)
-def assertDataFrameEqual(df: DataFrame, expected: DataFrame, check_row_order:
bool = False):
+def assertDataFrameEqual(
+ df: DataFrame,
+ expected: DataFrame,
+ check_row_order: bool = False,
Review Comment:
we decided to keep (renamed to `checkRowOrder`), with added documentation
clarifying that ordering isn't guaranteed unless df is explicitly sorted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]