cloud-fan commented on code in PR #41864:
URL: https://github.com/apache/spark/pull/41864#discussion_r1260455152
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala:
##########
@@ -208,3 +209,20 @@ case class CountMinSketchAgg(
confidenceExpression = third,
seedExpression = fourth)
}
+
+object CountMinSketchAggExpressionBuilder extends ExpressionBuilder {
+ final val functionSignature = FunctionSignature(Seq(
+ NamedArgument("column",
+ FixedArgumentType(TypeCollection(IntegralType, StringType,
BinaryType))),
+ NamedArgument("epsilon", FixedArgumentType(DoubleType)),
+ NamedArgument("confidence", FixedArgumentType(DoubleType)),
+ NamedArgument("seed", FixedArgumentType(IntegerType))
Review Comment:
It's good to make the new framework more capable, but we need to have a
clear vision for the eventual system. If eventually we only want the new
named-parameter framework to reorder the function parameters, and leave the
type check to the existing `Expression` framework, then the named-parameter
framework should not define the type information. If we want to move everything
to this new framework, we should design it well, by looking at existing
functions and define how everything should be done with the new framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
