learningchess2003 commented on code in PR #41864:
URL: https://github.com/apache/spark/pull/41864#discussion_r1261779139
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala:
##########
@@ -431,6 +432,22 @@ case class Explode(child: Expression) extends ExplodeBase {
copy(child = newChild)
}
+trait ExplodeGeneratorBuilderBase extends GeneratorBuilder {
+ override def functionSignatures: Option[Seq[FunctionSignature]] =
+ Some(Seq(FunctionSignature(Seq(NamedArgument("collection")))))
Review Comment:
To best explain this:
1. The option is used to check if named arguments will be supported for this
expression builder.
2. The seq is potentially useful in the future for function overloads.
3. There can be additional information that can be packaged into the
FunctionSignature in the future.
4. NamedArguments can hold additional information like default values.
So most of these things are pretty useful. For now, I think it makes sense
to keep as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
