cloud-fan commented on code in PR #41864:
URL: https://github.com/apache/spark/pull/41864#discussion_r1262230528
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -887,13 +887,46 @@ object FunctionRegistry {
since: Option[String] = None): (String, (ExpressionInfo,
FunctionBuilder)) = {
val (expressionInfo, builder) = FunctionRegistryBase.build[T](name, since)
val newBuilder = (expressions: Seq[Expression]) => {
+ if (expressions.exists(_.isInstanceOf[NamedArgumentExpression])) {
+ throw QueryCompilationErrors.namedArgumentsNotSupported(name)
+ }
val expr = builder(expressions)
if (setAlias) expr.setTagValue(FUNC_ALIAS, name)
expr
}
(name, (expressionInfo, newBuilder))
}
+ /**
+ * This method will be used to rearrange the arguments provided in function
invocation
+ * in the order defined by the function signature given in the builder
instance.
+ *
+ * @param name The name of the function
+ * @param builder The builder of the function expression
+ * @param expressions The argument list passed in function invocation
+ * @tparam T The class of the builder
+ * @return An argument list in positional order defined by the builder
+ */
+ def rearrangeExpressions[T <: Builder[_]](
+ name: String,
+ builder: T,
+ expressions: Seq[Expression]) : Seq[Expression] = {
+ val rearrangedExpressions = if (!builder.functionSignatures.isEmpty) {
+ val functionSignatures = builder.functionSignatures.get
+ if (functionSignatures.length != 1) {
Review Comment:
If we don't have a plan to support function overload soon, shall we restrict
it at compile time? `def functionSignatures: Option[Seq[FunctionSignature]] =
None` can be `def functionSignatures: Option[FunctionSignature] = None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
