juliuszsompolski commented on code in PR #41979:
URL: https://github.com/apache/spark/pull/41979#discussion_r1262250459


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala:
##########
@@ -45,9 +45,15 @@ import org.apache.spark.util.{SparkFatalException, 
ThreadUtils}
 trait BroadcastExchangeLike extends Exchange {
 
   /**
-   * The broadcast job group ID
+   * The broadcast run ID in job tag
    */
-  def runId: UUID = UUID.randomUUID
+  @transient
+  val runId: UUID = UUID.randomUUID

Review Comment:
   Before transient was on `jobTag`, which is deterministically derived from 
`runId`. Now as the `runId` is transient, will it not cause a new 
UUID.randomUUID to be regenerated if this classes is serialized and 
deserialized?
   I don't have full context of the implications so defer to @HyukjinKwon and 
@cloud-fan .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to