juliuszsompolski commented on code in PR #41979:
URL: https://github.com/apache/spark/pull/41979#discussion_r1262254441
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala:
##########
@@ -250,7 +250,7 @@ case class BroadcastQueryStageExec(
override def cancel(): Unit = {
if (!broadcast.relationFuture.isDone) {
- sparkContext.cancelJobGroup(broadcast.runId.toString)
+ sparkContext.cancelJobsWithTag(broadcast.jobTag)
Review Comment:
hm,
currently BroadcastExchangeExec.doBroacast only does cancelJobsWithTag when
it catches a TimeoutException.
Should we cancel there for broader exceptions (even any Throwable), and then
`broadcast.relationFuture.cancel(true)` here should throw there and cancel
there, and this place does not have to cancel separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
