rangadi commented on code in PR #41443:
URL: https://github.com/apache/spark/pull/41443#discussion_r1264125817


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2726,6 +2750,7 @@ class SparkConnectPlanner(val sessionHolder: 
SessionHolder) extends Logging {
     SparkConnectService.streamingSessionManager.registerNewStreamingQuery(
       sessionHolder = SessionHolder(userId = userId, sessionId = sessionId, 
session),
       query = query)
+    executeHolder.events.postFinished()

Review Comment:
   What is this? If it is just post of RPC, can we do it higher in the call 
stack?
   Also, it won't be posted if there is an error above this (e.g. query fails 
to start).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to