rangadi commented on code in PR #41443:
URL: https://github.com/apache/spark/pull/41443#discussion_r1264211837
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2726,6 +2750,7 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
SparkConnectService.streamingSessionManager.registerNewStreamingQuery(
sessionHolder = SessionHolder(userId = userId, sessionId = sessionId,
session),
query = query)
+ executeHolder.events.postFinished()
Review Comment:
I don't think so. There should be an exception otherwise, a query id is
returned.
> any exception thrown will go to ErrorUtils.handleError; that's where
failed is sent.
Hope there is only one place for success event as well like this. Better not
to repeat this code in many places like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
