juliuszsompolski commented on PR #41443: URL: https://github.com/apache/spark/pull/41443#issuecomment-1636514198
@rangadi : > Hope there is only one place for success event as well like this. I think the intention is to postFinished after the processing finished, but before the response is sent with `onNext`. I think that's why @jdesjean had to put it inside these commands? @jdesjean note however that this invariant doesn't hold in handleCommandPlugin already? Maybe it would be fine to postFinished after the onNext response with Commands? I think it makes little difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
