juliuszsompolski commented on code in PR #41964:
URL: https://github.com/apache/spark/pull/41964#discussion_r1266396999
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectServer.scala:
##########
@@ -49,6 +49,7 @@ object SparkConnectServer extends Logging {
SparkConnectService.server.awaitTermination()
} finally {
session.stop()
+ SparkConnectService.uiTab.foreach(_.detach())
Review Comment:
wouldn't SparkConnectService.stop() have been called already somewhere and
already detached it?
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -179,6 +182,9 @@ object SparkConnectService {
private[connect] var server: Server = _
+ var uiTab: Option[SparkConnectServerTab] = None
+ var listener: SparkConnectServerListener = _
Review Comment:
could both be private, or `private[connect]`?
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -259,13 +281,15 @@ object SparkConnectService {
if (debugMode) {
sb.addService(ProtoReflectionService.newInstance())
}
+
server = sb.build
server.start()
+ createListenerAndUI(sc)
Review Comment:
nit: maybe move `createListenerAndUI` to `start`, just like `detach` is in
`stop`. Then don't need to pass sc to `startGRPCService`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
