juliuszsompolski commented on code in PR #41964: URL: https://github.com/apache/spark/pull/41964#discussion_r1273856506
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/ui/SparkConnectServerListener.scala: ########## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connect.ui + +import scala.collection.mutable +import scala.collection.mutable.ArrayBuffer + +import org.apache.spark.{SparkConf, SparkContext, SparkEnv} +import org.apache.spark.internal.Logging +import org.apache.spark.internal.config.Status.LIVE_ENTITY_UPDATE_PERIOD +import org.apache.spark.scheduler._ +import org.apache.spark.sql.connect.config.Connect.{CONNECT_UI_SESSION_LIMIT, CONNECT_UI_STATEMENT_LIMIT} +import org.apache.spark.sql.connect.service._ +import org.apache.spark.sql.execution.SQLExecution +import org.apache.spark.status.{ElementTrackingStore, KVUtils, LiveEntity} + +private[connect] class SparkConnectServerListener( + kvstore: ElementTrackingStore, + sparkConf: SparkConf, + live: Boolean = true) + extends SparkListener + with Logging { + + private val sessionList = new mutable.LinkedHashMap[String, LiveSessionData] + private val executionList = new mutable.LinkedHashMap[String, LiveExecutionData] + + private val (retainedStatements: Int, retainedSessions: Int) = { + ( + SparkEnv.get.conf.get(CONNECT_UI_STATEMENT_LIMIT), + SparkEnv.get.conf.get(CONNECT_UI_SESSION_LIMIT)) + } + + // How often to update live entities. -1 means "never update" when replaying applications, + // meaning only the last write will happen. For live applications, this avoids a few + // operations that we can live without when rapidly processing incoming events. + private val liveUpdatePeriodNs = if (live) sparkConf.get(LIVE_ENTITY_UPDATE_PERIOD) else -1L + + // Returns true if this listener has no live data. Exposed for tests only. + private[connect] def noLiveData(): Boolean = synchronized { + sessionList.isEmpty && executionList.isEmpty + } + + kvstore.addTrigger(classOf[SessionInfo], retainedSessions) { count => + cleanupSession(count) + } + + kvstore.addTrigger(classOf[ExecutionInfo], retainedStatements) { count => + cleanupExecutions(count) + } + + override def onJobStart(jobStart: SparkListenerJobStart): Unit = { + val executionIdOpt: Option[String] = Option(jobStart.properties) + .flatMap { p => Option(p.getProperty(SQLExecution.EXECUTION_ID_KEY)) } + val jobTags = Option(jobStart.properties) + .flatMap { p => Option(p.getProperty(SparkContext.SPARK_JOB_TAGS)) } + .map(_.split(SparkContext.SPARK_JOB_TAGS_SEP).toSet) + .getOrElse(Set()) + .toSeq + .filter(!_.isEmpty) + .sorted + val execList = executionList.values.filter(exec => jobTags.contains(exec.jobTag)).toSeq Review Comment: @jasonli-db could you try to use https://github.com/juliuszsompolski/apache-spark/commit/639d515d629d78825489510eb98b3648e4122b04 to make it ``` val jobTag = jobTags.findFirst({ case ExecuteJobTag(jobTag) => jobexeclistTag } val exec = executionList.get(jobTag) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
