LuciferYang commented on code in PR #41932:
URL: https://github.com/apache/spark/pull/41932#discussion_r1266406645
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala:
##########
@@ -139,7 +139,18 @@ object SparkConnectServerUtils {
.map(clientTestJar => Seq("--jars", clientTestJar.getCanonicalPath))
.getOrElse(Seq.empty)
- writerV2Configs ++ hiveTestConfigs ++ udfTestConfigs
Review Comment:
re-check maven on master and with-this-pr:
**Before**
```
build/mvn clean -Phadoop-3 -Phadoop-cloud -Pmesos -Pyarn -Pkinesis-asl
-Phive-thriftserver -Pspark-ganglia-lgpl -Pkubernetes -Phive
build/mvn clean install -DskipTests -Phive
build/mvn clean test -pl connector/connect/client/jvm
```
```
Run completed in 2 minutes, 26 seconds.
Total number of tests run: 1099
Suites: completed 24, aborted 0
Tests: succeeded 1099, failed 0, canceled 0, ignored 1, pending 0
All tests passed.
```
**After**
```
gh pr checkout 41932
build/mvn clean -Phadoop-3 -Phadoop-cloud -Pmesos -Pyarn -Pkinesis-asl
-Phive-thriftserver -Pspark-ganglia-lgpl -Pkubernetes -Phive
build/mvn clean install -DskipTests -Phive
build/mvn clean test -pl connector/connect/client/jvm
```
Run completed in 1 minute, 29 seconds.
Total number of tests run: 1101
Suites: completed 24, aborted 0
Tests: succeeded 1033, failed 68, canceled 0, ignored 1, pending 0
*** 68 TESTS FAILED ***
```
A bit magical, but seems this pr has caused other cases to maven test fail.
Could you double check this ? @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
