cloud-fan commented on code in PR #41932:
URL: https://github.com/apache/spark/pull/41932#discussion_r1267506278
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -1161,6 +1161,27 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper with PrivateM
val joined = ds1.joinWith(ds2, $"a.value._1" === $"b.value._2", "inner")
checkSameResult(Seq((Some((2, 3)), Some((1, 2)))), joined)
}
+
+ test("call_function") {
+ val session: SparkSession = spark
+ import session.implicits._
+ val testData = spark.range(5).repartition(1)
+ try {
+ session.sql("CREATE FUNCTION custom_sum AS
'test.org.apache.spark.sql.MyDoubleSum'")
Review Comment:
I think it's OK to not test persist functions in spark connect, as it seems
hard to include the jar containing the UDF. The client-side implementation is
quite simple: constructs a small proto message and server-side turns it to
`UnresolvedFunction`. Making sure it works for builtin function is good enought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
