Hisoka-X commented on code in PR #42144:
URL: https://github.com/apache/spark/pull/42144#discussion_r1273372562


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/KeyGroupedPartitioningSuite.scala:
##########
@@ -310,9 +310,8 @@ class KeyGroupedPartitioningSuite extends 
DistributionAndOrderingSuiteBase {
 
   test("partitioned join: only one side reports partitioning") {
     val customers_partitions = Array(bucket(4, "customer_id"))
-    val orders_partitions = Array(bucket(2, "customer_id"))
 
-    testWithCustomersAndOrders(customers_partitions, orders_partitions, 2)

Review Comment:
   Yes, the result is same, but that's not the purpose of this test case. This 
test case is already covered in `partitioned join: number of buckets mismatch 
should trigger shuffle`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to