beliefer commented on code in PR #42144:
URL: https://github.com/apache/spark/pull/42144#discussion_r1273392123
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/KeyGroupedPartitioningSuite.scala:
##########
@@ -310,9 +310,8 @@ class KeyGroupedPartitioningSuite extends
DistributionAndOrderingSuiteBase {
test("partitioned join: only one side reports partitioning") {
val customers_partitions = Array(bucket(4, "customer_id"))
- val orders_partitions = Array(bucket(2, "customer_id"))
- testWithCustomersAndOrders(customers_partitions, orders_partitions, 2)
Review Comment:
Shall we modify testWithCustomersAndOrders and let the expected results are
different ? Otherwise, The test cases looks confused.
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/KeyGroupedPartitioningSuite.scala:
##########
@@ -310,9 +310,8 @@ class KeyGroupedPartitioningSuite extends
DistributionAndOrderingSuiteBase {
test("partitioned join: only one side reports partitioning") {
val customers_partitions = Array(bucket(4, "customer_id"))
- val orders_partitions = Array(bucket(2, "customer_id"))
- testWithCustomersAndOrders(customers_partitions, orders_partitions, 2)
Review Comment:
Shall we modify `testWithCustomersAndOrders` and let the expected results
are different ? Otherwise, The test cases looks confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
