LuciferYang commented on code in PR #42139:
URL: https://github.com/apache/spark/pull/42139#discussion_r1275674877
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitmapExpressions.scala:
##########
@@ -248,9 +258,17 @@ case class BitmapOrAgg(child: Expression,
override def checkInputDataTypes(): TypeCheckResult = {
if (child.dataType != BinaryType) {
- TypeCheckResult.TypeCheckFailure("Bitmap must be a BinaryType")
+ DataTypeMismatch(
Review Comment:
```
Why are the changes needed?
It appears TypeCheckResult.TypeCheckFailure has been deprecated: No
expressions except for the recently added BitmapCount and BitmapOrAgg are using
it.
```
@bersprockets On the other hand, even though the pr has been merged, could
you modify the PR description? From the suggestions of @cloud-fan and
@zhengruifeng , there is currently no intention to make TypeCheckFailure
deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
