zhengruifeng commented on code in PR #42139:
URL: https://github.com/apache/spark/pull/42139#discussion_r1275675054
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitmapExpressions.scala:
##########
@@ -248,9 +258,17 @@ case class BitmapOrAgg(child: Expression,
override def checkInputDataTypes(): TypeCheckResult = {
if (child.dataType != BinaryType) {
- TypeCheckResult.TypeCheckFailure("Bitmap must be a BinaryType")
+ DataTypeMismatch(
Review Comment:
I think we should use deprecation only when we have to remove it in the
future.
An example is the Pandas 2.0 Upgrade, Pandas 2.0 has introduced a lot of
breaking changes, some APIs/parameters were removed. So in Pandas API on Spark,
we will have to make similar changes for Pandas parity, e.g.
https://github.com/apache/spark/blob/a367fde24de0abab93eac97350fb4ae0b687286c/python/pyspark/pandas/frame.py#L2060-L2072
https://github.com/apache/spark/blob/20a8fc87d67c842ac3386dc6ae0c53a9533900c2/python/pyspark/pandas/series.py#L1684-L1687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
