ulysses-you commented on code in PR #41628:
URL: https://github.com/apache/spark/pull/41628#discussion_r1280501851
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala:
##########
@@ -162,33 +193,36 @@ case class InsertIntoHadoopFsRelationCommand(
retainData = true /* already deleted */).run(sparkSession)
}
}
+ // The `customPartitionLocations` is getting from writing paths.
Hence, it need to move
+ // files from `qualifiedOutputPath` to custom location.
+ if (updatedPartitions.nonEmpty && dynamicPartitionOverwrite) {
Review Comment:
> so all files write to the default partition path, if there is some custom
partition path, we need to move the data to the custom partition inside
I do not quite follow it. Before this pr, it should already be done inside
commit protocol. Does this pr changes the commit protocol ? What's the relation
between this method and `HadoopMapReduceCommitProtocol.commitJob` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
