ulysses-you commented on code in PR #41628:
URL: https://github.com/apache/spark/pull/41628#discussion_r1281312902
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala:
##########
@@ -162,33 +193,36 @@ case class InsertIntoHadoopFsRelationCommand(
retainData = true /* already deleted */).run(sparkSession)
}
}
+ // The `customPartitionLocations` is getting from writing paths.
Hence, it need to move
+ // files from `qualifiedOutputPath` to custom location.
+ if (updatedPartitions.nonEmpty && dynamicPartitionOverwrite) {
Review Comment:
I see, this pr changes the output spec. But it's risky, there is a lot of
history about that... After this change, there are many things chagned:
- rename partition location twice, once is at commit protocol and the other
is in this method
- so the dynamic partition write staging dir changed. This pr has two
staging dir since there is one more rename operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
