attilapiros commented on code in PR #42392:
URL: https://github.com/apache/spark/pull/42392#discussion_r1287542152
##########
python/pyspark/pandas/tests/test_resample.py:
##########
@@ -252,14 +254,32 @@ def test_dataframe_resample(self):
self._test_resample(self.pdf5, self.psdf5, ["55MIN", "2H", "D"],
"left", "left", "std")
self._test_resample(self.pdf6, self.psdf6, ["29S", "10MIN", "3H"],
"left", "right", "var")
- def test_series_resample(self):
+ def check_series_resample(self):
self._test_resample(self.pdf1.A, self.psdf1.A, ["4Y"], "right", None,
"min")
self._test_resample(self.pdf2.A, self.psdf2.A, ["13M"], "right",
"left", "max")
self._test_resample(self.pdf3.A, self.psdf3.A, ["1001H"], "right",
"right", "sum")
self._test_resample(self.pdf4.A, self.psdf4.A, ["6D"], None, None,
"mean")
self._test_resample(self.pdf5.A, self.psdf5.A, ["47T"], "left",
"left", "var")
self._test_resample(self.pdf6.A, self.psdf6.A, ["111S"], "right",
"right", "std")
+ def test_series_resample(self):
+ self.check_series_resample()
Review Comment:
We are still depending on the TZ environment setting indirectly. So just by
running the test on a different TZ this test (and also the
test_dataframe_resample) would simply fail.
We should either guarantee the correct TZ in the beginning of the test or
validate the assumption and produce a meaningful error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
