ramesh-muthusamy commented on code in PR #42416:
URL: https://github.com/apache/spark/pull/42416#discussion_r1289513072


##########
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala:
##########
@@ -59,6 +61,7 @@ class StatsdSinkSuite extends SparkFunSuite {
     val props = new Properties
     defaultProps.foreach(e => props.put(e._1, e._2))
     props.put(STATSD_KEY_PORT, socket.getLocalPort.toString)
+    props.put(STATSD_KEY_REGEX, 
"test-[0-9]+.driver.(CodeGenerator|BlockManager)")

Review Comment:
   All of them were timing out locally, I wondered if that was to do with the 
statsd setup. In this case looks like the timeout is happening since the test 
keeps waiting for the result and filter is blocking the message from being 
sent. I confirmed this behaviour locally and have resolved the same. The 
StatsdTestSuite now  runs successfully locally. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to