LuciferYang commented on code in PR #42414:
URL: https://github.com/apache/spark/pull/42414#discussion_r1289576443
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/BloomFilterAggregate.scala:
##########
@@ -150,6 +151,15 @@ case class BloomFilterAggregate(
Math.min(numBitsExpression.eval().asInstanceOf[Number].longValue,
SQLConf.get.getConf(RUNTIME_BLOOM_FILTER_MAX_NUM_BITS))
+ // Mark as lazy so that `updater` is not evaluated during tree
transformation.
+ private lazy val updater: BloomFilterUpdater = first.dataType match {
Review Comment:
Yes, but I haven't thought of other ways yet. This is similar to the cases
of `estimatedNumItems` and `numBits`. If it's not `lazy`, then there will be an
issue of `Invalid call to dataType on unresolved object`
https://github.com/apache/spark/blob/55b07b1367a78d5431ce2043fcd590fc4409d566/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/BloomFilterAggregate.scala#L143-L151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
