hvanhovell commented on code in PR #42414:
URL: https://github.com/apache/spark/pull/42414#discussion_r1293546122
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1730,6 +1731,36 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
val ignoreNulls = extractBoolean(children(3), "ignoreNulls")
Some(Lead(children.head, children(1), children(2), ignoreNulls))
+ case "bloom_filter_agg" if fun.getArgumentsCount == 3 =>
+ // [col, expectedNumItems: Long, numBits: Long]
+ val children = fun.getArgumentsList.asScala.map(transformExpression)
+
+ // Check expectedNumItems is LongType and value greater than 0L
+ val expectedNumItemsExpr = children(1)
+ val expectedNumItems = expectedNumItemsExpr match {
Review Comment:
We can do that in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]