WeichenXu123 commented on code in PR #42382:
URL: https://github.com/apache/spark/pull/42382#discussion_r1290837783
##########
mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala:
##########
@@ -405,12 +405,14 @@ private[ml] object DefaultParamsWriter {
def saveMetadata(
instance: Params,
path: String,
- sc: SparkContext,
Review Comment:
Yes this might be an issue, e.g. xgboost4j-spark lib is influenced:
https://github.com/dmlc/xgboost/blob/d6385355815005625115b648f6b7dc861eacd47e/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostClassifier.scala#L494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
