srowen commented on code in PR #42382:
URL: https://github.com/apache/spark/pull/42382#discussion_r1290838818
##########
mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala:
##########
@@ -405,12 +405,14 @@ private[ml] object DefaultParamsWriter {
def saveMetadata(
instance: Params,
path: String,
- sc: SparkContext,
Review Comment:
I don't think that much is directly relevant to Spark; there is just no
reason to break compatibility when it's easy to keep the existing method too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
