cloud-fan commented on code in PR #41782:
URL: https://github.com/apache/spark/pull/41782#discussion_r1299550466
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java:
##########
@@ -84,9 +84,7 @@ public long valuesNativeAddress() {
return data;
}
- @Override
- public void close() {
- super.close();
+ private void releaseMemory() {
Review Comment:
nit: if we can move the declartion of this function to the parent class,
then `reset` and `close` can both be implementd in the parent class. The child
classes only need to implement `releaseMemory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
