cloud-fan commented on code in PR #41782:
URL: https://github.com/apache/spark/pull/41782#discussion_r1305161593
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -487,6 +487,26 @@ object SQLConf {
.intConf
.createWithDefault(10000)
+ val VECTORIZED_HUGE_VECTOR_RESERVE_RATIO =
+ buildConf("spark.sql.inMemoryColumnarStorage.hugeVectorReserveRatio")
+ .doc("When spark.sql.inMemoryColumnarStorage.hugeVectorThreshold <= 0 or
the required " +
+ "memory is smaller than
spark.sql.inMemoryColumnarStorage.hugeVectorThreshold, spark " +
+ "reserves required memory * 2 memory; otherwise, spark reserves " +
+ "required memory * this ratio memory, and will release this column
vector memory before " +
+ "reading the next batch rows.")
+ .version("3.5.0")
Review Comment:
one last comment: 3.5.0 is already at RC2 and it's too late to merge this
feature to 3.5. Can we update it to 4.0.0?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -487,6 +487,26 @@ object SQLConf {
.intConf
.createWithDefault(10000)
+ val VECTORIZED_HUGE_VECTOR_RESERVE_RATIO =
+ buildConf("spark.sql.inMemoryColumnarStorage.hugeVectorReserveRatio")
+ .doc("When spark.sql.inMemoryColumnarStorage.hugeVectorThreshold <= 0 or
the required " +
+ "memory is smaller than
spark.sql.inMemoryColumnarStorage.hugeVectorThreshold, spark " +
+ "reserves required memory * 2 memory; otherwise, spark reserves " +
+ "required memory * this ratio memory, and will release this column
vector memory before " +
+ "reading the next batch rows.")
+ .version("3.5.0")
+ .doubleConf
+ .createWithDefault(1.2)
+
+ val VECTORIZED_HUGE_VECTOR_THRESHOLD =
+ buildConf("spark.sql.inMemoryColumnarStorage.hugeVectorThreshold")
+ .doc("When the required memory is larger than this, spark reserves
required memory * " +
+ s"${VECTORIZED_HUGE_VECTOR_RESERVE_RATIO.key} memory next time and
release this column " +
+ s"vector memory before reading the next batch rows. -1 means disabling
the optimization.")
+ .version("3.5.0")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
