dongjoon-hyun commented on code in PR #42542:
URL: https://github.com/apache/spark/pull/42542#discussion_r1300792351
##########
core/src/main/scala/org/apache/spark/ui/SparkUI.scala:
##########
@@ -100,6 +101,13 @@ private[spark] class SparkUI private (
attachTab(stagesTab)
attachTab(new StorageTab(this, store))
attachTab(new EnvironmentTab(this, store))
+ if (sc.map(_.conf.get(DRIVER_LOG_LOCAL_DIR).nonEmpty).getOrElse(false)) {
+ val driverLogTab = new DriverLogTab(this)
+ attachTab(driverLogTab)
+ attachHandler(createServletHandler("/log",
Review Comment:
It's used as the REST API prefix, `https://driver/log` and it should be
`log` in order to reuse the existing `log-view.js` Javascript of Worker UIs.
https://github.com/apache/spark/blob/8d4ca0aa580f9622eb6f74bb99ae8a3e4e9667d5/core/src/main/resources/org/apache/spark/ui/static/log-view.js#L57-L66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
