dongjoon-hyun commented on code in PR #42542:
URL: https://github.com/apache/spark/pull/42542#discussion_r1300793673
##########
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:
##########
@@ -219,6 +223,11 @@ private[spark] object DriverLogger extends Logging {
logError("Could not add driver logger", e)
None
}
+ } else if (localDriverLogEnabled) {
+ // Driver Logger is started only for Spark Driver Log UI Tab
+ new DriverLogger(conf)
+ // Return None because we don't need DFS-related logic in SparkContext
and DfsAsyncWriter
Review Comment:
BTW, this is a live UI. So, when the driver JVM stopped, the log is supposed
to be lost. In addition, when `DRIVER_LOG_PERSISTTODFS` is set, it will follow
the original path including invoking `stop` and `sync`. However,
`DRIVER_LOG_PERSISTTODFS` is a separate logic which we need to investigate if
it works as designed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
