zhengruifeng commented on PR #42775: URL: https://github.com/apache/spark/pull/42775#issuecomment-1703769617
> I'm good with this change. But from the demo, I found another issue: Do we need to maintain consistent capitalization of function names, such as: <img alt="image" width="609" src="https://user-images.githubusercontent.com/15246973/265193339-c54fb4b9-55b3-4300-8b06-ca757284e5eb.png";> 1.Whether written in uppercase or lowercase, the display is lowercase. 2.Some are lowercase and some are uppercase. > > **Of course, this is another issue.** In sql, uppercase/lowercase don't affect the output column name: ``` scala> spark.sql("SELECT sign(-1), SIGN(-1), signum(-1), SIGNUM(-1)").show +--------+--------+----------+----------+ |sign(-1)|sign(-1)|SIGNUM(-1)|SIGNUM(-1)| +--------+--------+----------+----------+ | -1.0| -1.0| -1.0| -1.0| +--------+--------+----------+----------+ ``` It seems there is not a criterion of the style. yeah, this PR only aims to make the newly added functions generate the same default names with SQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15246973/265193339-c54fb4b9-55b3-4300-8b06-ca757284e5eb.png"](https://user-images.githubusercontent.com/15246973/265193339-c54fb4b9-55b3-4300-8b06-ca757284e5eb.png"){kind=link}