zhengruifeng commented on code in PR #42775:
URL: https://github.com/apache/spark/pull/42775#discussion_r1314347624
##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -1052,15 +1049,15 @@ object functions {
* @group agg_funcs
* @since 3.5.0
*/
- def std(e: Column): Column = stddev(e)
+ def std(e: Column): Column = call_function("std", e)
/**
* Aggregate function: alias for `stddev_samp`.
*
* @group agg_funcs
* @since 1.6.0
*/
- def stddev(e: Column): Column = withAggregateFunction { StddevSamp(e.expr) }
+ def stddev(e: Column): Column = call_function("stddev", e)
Review Comment:
good catch! it was since 1.6.0.
but what about keeping this change, otherwise it make SQL/Connect(both Scala
Client and Python Client) different from vanilla Spark(Python and Scala)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
