LuciferYang commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1325276129
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
If this is the case, they should be put into `v35excludes` for future
unified cleanup, rather than being placed into `defaultExcludes`. The items
placed into `defaultExcludes` generally represent the rules that will never
participate in the mima check. ~I've submitted a PR to move the similar cases
to v35excludes : https://github.com/apache/spark/pull/42912~
delete them in https://github.com/apache/spark/pull/42921, please help to
check if you have time. thanks
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
If this is the case, they should be put into `v35excludes` for future
unified cleanup, rather than being placed into `defaultExcludes`. The items
placed into `defaultExcludes` generally represent the rules that will never
participate in the mima check. ~I've submitted a PR to move the similar cases
to v35excludes : https://github.com/apache/spark/pull/42912~
Delete them in https://github.com/apache/spark/pull/42921, please help to
check if you have time. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
